-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Go modules #168
Use Go modules #168
Conversation
Simply ran `go mod init github.com/pagerduty/go-pagerduty` Converted `PagerDuty/go-pagerduty` to match lowercased package nameing standards https://blog.golang.org/package-names Updated the `github.com/Sirupsen/logrus` import to current lowercase name
@stmcallister Did you get a chance to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Modules are still experimental I'd personally like to avoid adopting them until they are more stable.
Modules are used by basically every opensource go project. while its still beta (last i read they are targeting release in 1.14) its the most supported package manager out there for go. Little has changed in the actual API of modules in the last few releases, so i would say is stable. |
I'm leaning toward @nbutton23 on this one. I'll take a look at this tomorrow. |
@nbutton23 -- We're still discussing this a bit internally. If I understand it correctly, going to modules will require all existing projects using this library to be moved out of the $GOPATH, which means everyone's projects will break once we release. Is there a smoother way to make this transition? |
@stmcallister It shouldn't break anything. Right now by default GO111MODULE is set to auto. If they are not using mods then nothing will change.
|
@nbutton23 Except that it broke for me. 😄
I'm guessing this is because the package name changed from |
Ah yeah thats not the module is self. Its the change made to match naming standards. I can pull that out. . . |
@nbutton23 Yeah, I see what you're saying. However, if changing the package name at this point is going to break existing apps and negatively affect current users, we want to avoid making that change. If you go ahead and take that out, the rest of the PR looks good. |
@stmcallister Done! |
@nbutton23 Awesome! Thanks! LGTM. |
@theckman Thanks for expressing your concern, but we've looked at this internally and have decided this is the direction we want to go with the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using modules is the direction we're hoping to take the library. Also, thank you for fixing the logrus bug.
Simply ran
go mod init github.com/pagerduty/go-pagerduty
Converted
PagerDuty/go-pagerduty
to match lowercased package nameing standardshttps://blog.golang.org/package-names
Updated the
github.com/Sirupsen/logrus
import to current lowercase name