Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported fields to POST /incident request. #151

Merged
merged 2 commits into from
Oct 23, 2019

Conversation

archydragon
Copy link

@electrofelix
Copy link

@stmcallister I see there are two PRs for enabling the ability to create incidents with Urgency, this one and #147, would it be possible to have one of them land (once the conflict is resolved)?

@stmcallister
Copy link
Contributor

@electrofelix yep. i'll look at these right now and see if we can get one of them merged.

@stmcallister
Copy link
Contributor

Thank you for making this contribution! This looks good to me.

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks. I made a minor change where fields of type APIReference and APIDetails need to remain pointers. Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants