Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Annotation parameters v2 #19

Merged
merged 3 commits into from
Aug 3, 2022
Merged

fix: Annotation parameters v2 #19

merged 3 commits into from
Aug 3, 2022

Conversation

CodeCasterNL
Copy link
Contributor

In this code:

/**
 * @Job(group="my-group", logFile="myjob.log", commandLine="my:job 42 --first-option --second-option true")
 */

The commandLine parameter was ignored, and the code would default to the command name (my:job in this case).

Tests/HelperTest.php Outdated Show resolved Hide resolved
Tests/HelperTest.php Outdated Show resolved Hide resolved
Tests/HelperTest.php Outdated Show resolved Hide resolved
@CodeCasterNL
Copy link
Contributor Author

I rebased my v3 branch and committed too eagerly after testing too little, should be better now.

@CodeCasterNL CodeCasterNL requested a review from Padam87 August 3, 2022 17:32
@Padam87 Padam87 merged commit e04af5e into Padam87:v2.x Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants