feat: php 8 attributes added #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @dragondungeon1, Thank you for your effort, but there are too many things in this PR that I would not like to allow. If you are willing to change that, I'll start a review, otherwise please close it. Thanks, |
Padam87
requested changes
Jul 22, 2022
|
Dear Adam, thank you for your review. I will work on this :) |
dragondungeon1
commented
Jul 25, 2022
286996b to
94bf2e7
Compare
Padam87
reviewed
Jul 25, 2022
|
Thank you @dragondungeon1 ! Release will come soon, but I will add a test suite with a few tests first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created attributes for php 8.
Since this bundle is only used by users who are running php 7.4 or higher i've decided to update the composer.json to the minum version of php 7.4.
source: https://packagist.org/packages/padam87/cron-bundle/php-stats
When people are using php 7.4 they can still make use of the annotations.
Also I've updated the README so people are aware that this bundle does make usage of attributes.