Deskew the scans by default #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benemer
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Deprecate the
--deskewoption, as now, in the aftermath of #429, we decided to deskew the scans by default. If the--deskewis provided we communicate to the user through a warning that we might remove this option in future versions. Furthermore, by default, we advertise to the user that now we deskew the scans by default. This makes sense as, if timestamps are available, there is no reason to don't motion compensate. If some external pipeline already deskews the scans, the user must provide a custom config wheredeskew=False. This in general should be an exception, as it turns out that constant velocity deskewing is even better than what we used to think 2 years ago. An example on Sejong01:No Deskew
Deskew