Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Solution class for steady state simulations #2222

Closed
ma-sadeghi opened this issue Dec 9, 2021 · 4 comments · Fixed by #2246
Closed

Implement Solution class for steady state simulations #2222

ma-sadeghi opened this issue Dec 9, 2021 · 4 comments · Fixed by #2246
Assignees

Comments

@ma-sadeghi
Copy link
Member

Currently, Solution object is only implemented for transient simulations.

@ma-sadeghi ma-sadeghi added this to the v3.0 - API changes milestone Dec 9, 2021
@ma-sadeghi
Copy link
Member Author

What added value does a SteadyStateSolution class provide? Is it just for consistency with transient algs?

@jgostick
Copy link
Member

Yes, mostly for consistency, but there are perhaps features we'll add to the Solution class in the future which could be useful for both transient and steady-state. For instance, the solver convergence if interative, run times, etc.

@jgostick
Copy link
Member

Also, for instance, see #2053. In fact, we also have the rate method on algorithms, which perhaps should be on the solution object, instead of the algorithm? Maybe?

@jgostick
Copy link
Member

Also, it seems to me like the the conductance should be copied to the solution object, so there is a permanent record of the values in case they are changed on the physics object. Same for any reactions terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants