-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a bazel-built example. #196
Conversation
Awesome, thank you! Could you please take a look at the comment I left inline? Maybe I'm just missing something. |
I don't see a comment, which file? |
In examples/bazel/third_party/libcbor.BUILD, the cc_import rule is commented out The script section of https://github.com/PJK/libcbor/blob/master/.travis.yml should basically also build the example. I can take a look at this. |
I fixed the BUILD file.
I don't see that yml file... I'm still kind of a newbie about GitHub....
…On Sun, Oct 10, 2021 at 11:04 AM Pavel Kalvoda ***@***.***> wrote:
In examples/bazel/third_party/libcbor.BUILD, the cc_import rule is
commented out
The script section of
https://github.com/PJK/libcbor/blob/master/.travis.yml should basically
also build the example. I can take a look at this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AK5GJQT5SU2U3ETEBTCUDIDUGHIT5ANCNFSM5FDHMP6A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
--
Andrew John, Google Fonts
|
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
==========================================
- Coverage 95.60% 95.48% -0.13%
==========================================
Files 47 47
Lines 3325 3325
Branches 172 172
==========================================
- Hits 3179 3175 -4
- Misses 98 101 +3
- Partials 48 49 +1
Continue to review full report at Codecov.
|
This is what I meant: 72dc859 |
PR: Add an example to the examples directory, showing how to use libcbor with Bazel
Description
Add an example to the examples directory, showing how to use libcbor with Bazel
Checklist