Remove rockdev explorer #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cheery-moxie-4f1121 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Liquid369
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
This PR simply removes the now-defunct Rockdev explorer by Sparrow - as you can see by the home page, this explorer has been shut down - in the case that it comes back in the future, we could re-add it, but there's no point in keeping a dead explorer in MPW at the moment.
Duddino's explorer has been set as the new default in replacement, with zkBitcoin being second.
According to the Settings logic, even if Rockdev is someone's chosen explorer; if MPW cannot find the explorer in the ChainParams, it will use the default explorer, so no other changes should be necessary for a safe removal.
Testing
To test this PR, it's suggested to attempt these user flows, or variations of these:
Rockdevas your chosen explorer, apply the PR, then ensure MPW switches to Duddino's explorer.If any errors are found, the PR works unexpectedly, or you have viable suggestions to improve the UX or functionality of the PR, let me know!