Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Add unit tests for AccessWallet #279

Merged
merged 2 commits into from
Dec 8, 2023
Merged

[TEST] Add unit tests for AccessWallet #279

merged 2 commits into from
Dec 8, 2023

Conversation

panleone
Copy link
Member

@panleone panleone commented Dec 7, 2023

Abstract

Add unit test coverage for the AccessWallet class

  • Test different scenario of secret + password input by the user
  • Test that the final event import-wallet is emitted with correct values
  • Test that elements are visible only when they should be

@panleone panleone self-assigned this Dec 7, 2023
@panleone panleone added the Test Addition of unit or functional test label Dec 7, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 7, 2023 •
edited
Loading

✅ Deploy Preview for cheery-moxie-4f1121 ready!

Name Link
🔨 Latest commit 3a5279b
🔍 Latest deploy log https://app.netlify.com/sites/cheery-moxie-4f1121/deploys/65724de106331400086f4328
😎 Deploy Preview https://deploy-preview-279--cheery-moxie-4f1121.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Duddino
Duddino approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@Duddino Duddino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK great tests, a lot of the edge cases have been covered. Can't think of anything else to add

Liquid369
Liquid369 approved these changes Dec 8, 2023
View reviewed changes
Copy link

@Liquid369 Liquid369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3a5279b

@Duddino Duddino merged commit 1a49785 into PIVX-Labs:master Dec 8, 2023
@panleone panleone mentioned this pull request Dec 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liquid369 Liquid369 Liquid369 approved these changes

@Duddino Duddino Duddino approved these changes

Assignees

@panleone panleone

Labels
Test Addition of unit or functional test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panleone @Liquid369 @Duddino