Don't allow big txs on ledger (#488)

* Don't allow big txs on ledger * Add error checking * Fix duplicated code * Remove more duplicated keys * Fix build * Idk where commets went but here they are again
PIVX-Labs · Jan 23, 2025 · 552cca6 · 552cca6
1 parent 05d5883
commit 552cca6
Show file tree

Hide file tree

Showing 16 changed files with 24 additions and 4 deletions.
diff --git a/locale/cnr/translation.toml b/locale/cnr/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/de/translation.toml b/locale/de/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/en/translation.toml b/locale/en/translation.toml
@@ -316,6 +316,7 @@ WALLET_UNLOCKED = "Wallet successfully Unlocked!" # Wallet successfully Unlocked
 CONFIRM_LEDGER_TX = "Confirm this transaction matches the one on your {hardwareWallet}" # Confirm this transaction matches the one on your {hardwareWallet}
 CONFIRM_LEDGER_TX_OUT = "You will send {value} {ticker} to <div class=\"inline-address\">{address}</div>" # You will send {value} {ticker} to <div class="inline-address">{address}</div>
 MISSING_SHIELD = "Shield is not enabled in this wallet!" # Shield is not enabled in this wallet!
-MN_START_FAILED = "<b>Masternode failed to start!</b>" # <b>Masternode failed to start!</b>
-MN_RESTART_FAILED = "<b>Masternode failed to restart!</b>" # <b>Masternode failed to restart!</b>
+MN_START_FAILED = " <b>Masternode failed to start!</b>" # <b>Masternode failed to start!</b>
+MN_RESTART_FAILED = " <b>Masternode failed to restart!</b>" # <b>Masternode failed to restart!</b>
+LEDGER_TX_TOO_BIG = "Transaction length exceeds 9000 bytes" # Transaction length exceeds 9000 bytes
 MISSING_FUNDS = "<b>Balance is too small!</b> <br> Missing {sats} sats!" # <b>Balance is too small!</b> <br> Missing {sats} sats!
diff --git a/locale/es-mx/translation.toml b/locale/es-mx/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/fr/translation.toml b/locale/fr/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/hi/translation.toml b/locale/hi/translation.toml
@@ -319,3 +319,4 @@ MISSING_FUNDS = "बैलेंस बहुत कम है! {sats} सैट
 MISSING_SHIELD = "इस वॉलेट में शील्ड सक्षम नहीं है!" # Shield is not enabled in this wallet!
 WALLET_HARDWARE_USB_UNSUPPORTED = "" # <b>Firefox doesn't support this!</b><br>Unfortunately, Firefox does not support hardware wallets
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/it/translation.toml b/locale/it/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "Lo Shield non è abilitato nel wallet!" # Shield is not enable
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/nl/translation.toml b/locale/nl/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/ph/translation.toml b/locale/ph/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/pl/translation.toml b/locale/pl/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/pt-br/translation.toml b/locale/pt-br/translation.toml
@@ -132,3 +132,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/pt-pt/translation.toml b/locale/pt-pt/translation.toml
@@ -132,3 +132,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/locale/template/translation.toml b/locale/template/translation.toml
@@ -341,5 +341,6 @@ CONFIRM_POPUP_DELETE_ACCOUNT = 'This will delete all your data, including master
 CONFIRM_POPUP_DELETE_ACCOUNT_TITLE = 'Are you sure?'
 CONFIRM_LEDGER_TX = 'Confirm this transaction matches the one on your {hardwareWallet}'
 CONFIRM_LEDGER_TX_OUT = 'You will send {value} {ticker} to <div class="inline-address">{address}</div>'
+LEDGER_TX_TOO_BIG = 'Transaction length exceeds 9000 bytes'
 MISSING_FUNDS = '<b>Balance is too small!</b> <br> Missing {sats} sats!'
 MISSING_SHIELD = "Shield is not enabled in this wallet!"
diff --git a/locale/uwu/translation.toml b/locale/uwu/translation.toml
@@ -319,3 +319,4 @@ MISSING_SHIELD = "" # Shield is not enabled in this wallet!
 MN_START_FAILED = "" # <b>Masternode failed to start!</b>
 MN_RESTART_FAILED = "" # <b>Masternode failed to restart!</b>
 MN_UNLOCK_WALLET = "" # Please import your <b> COLLATERAL WALLET</b> first.
+LEDGER_TX_TOO_BIG = "" # Transaction length exceeds 9000 bytes
diff --git a/scripts/ledger.js b/scripts/ledger.js
@@ -151,7 +151,12 @@ export async function getHardwareWalletKeys(path, xpub = false, verify = true) {
  */
 export async function ledgerSignTransaction(wallet, transaction) {
     await setupConnection();
-    const ledgerTx = cHardwareWallet.splitTransaction(transaction.serialize());
+    const txHex = transaction.serialize();
+    if (txHex.length / 2 > 9000) {
+        createAlert('warning', ALERTS.LEDGER_TX_TOO_BIG, 10_000);
+        return false;
+    }
+    const ledgerTx = cHardwareWallet.splitTransaction(txHex);
     const outputs = transaction.vout.map((o) => {
         const { addresses, type } = wallet.getAddressesFromScript(o.script);
         if (type !== 'p2pkh') {

diff --git a/scripts/legacy.js b/scripts/legacy.js
@@ -36,7 +36,8 @@ export async function createAndSendTransaction({
     });
     if (!wallet.isHardwareWallet()) await wallet.sign(tx);
     else {
-        await ledgerSignTransaction(wallet, tx);
+        const res = await ledgerSignTransaction(wallet, tx);
+        if (!res) return;
     }
     const res = await getNetwork().sendTransaction(tx.serialize());
     if (res) {