fix tests wip

Signed-off-by: Zixuan James Li <zixuan@zulip.com>
PIG208 · Dec 30, 2024 · c77bbad · c77bbad
1 parent 48316ed
commit c77bbad
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 14 deletions.
diff --git a/test/widgets/content_test.dart b/test/widgets/content_test.dart
@@ -482,7 +482,7 @@ void main() {
       final expectedLaunchUrl = expectedVideo.hrefUrl;
       await tester.tap(find.byIcon(Icons.play_arrow_rounded));
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse(expectedLaunchUrl), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse(expectedLaunchUrl), mode: LaunchMode.inAppBrowserView));
     }
 
     testWidgets('video preview for youtube embed', (tester) async {
@@ -754,7 +754,7 @@ void main() {
       await tapText(tester, find.text('hello'));
 
       final expectedLaunchMode = defaultTargetPlatform == TargetPlatform.iOS ?
-        LaunchMode.externalApplication : LaunchMode.platformDefault;
+        LaunchMode.externalApplication : LaunchMode.inAppBrowserView;
       check(testBinding.takeLaunchUrlCalls())
         .single.equals((url: Uri.parse('https://example/'), mode: expectedLaunchMode));
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
@@ -772,19 +772,19 @@ void main() {
 
       await tester.tapAt(base.translate(1*fontSize, 0)); // "fXo bar baz"
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.inAppBrowserView));
 
       await tester.tapAt(base.translate(9*fontSize, 0)); // "foo bar bXz"
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://b/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://b/'), mode: LaunchMode.inAppBrowserView));
     });
 
     testWidgets('link nested in other spans', (tester) async {
       await prepare(tester,
         '<p><strong><em><a href="https://a/">word</a></em></strong></p>');
       await tapText(tester, find.text('word'));
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.inAppBrowserView));
     });
 
     testWidgets('link containing other spans', (tester) async {
@@ -797,27 +797,27 @@ void main() {
 
       await tester.tapAt(base.translate(1*fontSize, 0)); // "tXo words"
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.inAppBrowserView));
 
       await tester.tapAt(base.translate(6*fontSize, 0)); // "two woXds"
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.inAppBrowserView));
     });
 
     testWidgets('relative links are resolved', (tester) async {
       await prepare(tester,
         '<p><a href="/a/b?c#d">word</a></p>');
       await tapText(tester, find.text('word'));
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('${eg.realmUrl}a/b?c#d'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('${eg.realmUrl}a/b?c#d'), mode: LaunchMode.inAppBrowserView));
     });
 
     testWidgets('link inside HeadingNode', (tester) async {
       await prepare(tester,
         '<h6><a href="https://a/">word</a></h6>');
       await tapText(tester, find.text('word'));
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('https://a/'), mode: LaunchMode.inAppBrowserView));
     });
 
     testWidgets('error dialog if invalid link', (tester) async {
@@ -827,7 +827,7 @@ void main() {
       await tapText(tester, find.text('word'));
       await tester.pump();
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: Uri.parse('file:///etc/bad'), mode: LaunchMode.platformDefault));
+        .single.equals((url: Uri.parse('file:///etc/bad'), mode: LaunchMode.inAppBrowserView));
       checkErrorDialog(tester, expectedTitle: 'Unable to open link');
     });
   });
@@ -871,7 +871,7 @@ void main() {
       await tapText(tester, find.text('invalid'));
       final expectedUrl = eg.realmUrl.resolve('/#narrow/stream/1-check/topic');
       check(testBinding.takeLaunchUrlCalls())
-        .single.equals((url: expectedUrl, mode: LaunchMode.platformDefault));
+        .single.equals((url: expectedUrl, mode: LaunchMode.inAppBrowserView));
       check(pushedRoutes).isEmpty();
     });
   });

diff --git a/test/widgets/profile_test.dart b/test/widgets/profile_test.dart
@@ -164,7 +164,7 @@ void main() {
       await tester.tap(find.text(testUrl));
       check(testBinding.takeLaunchUrlCalls()).single.equals((
         url: Uri.parse(testUrl),
-        mode: LaunchMode.platformDefault,
+        mode: LaunchMode.inAppBrowserView,
       ));
     });
 
@@ -191,7 +191,7 @@ void main() {
       await tester.tap(find.text('externalValue'));
       check(testBinding.takeLaunchUrlCalls()).single.equals((
         url: Uri.parse('http://example/externalValue'),
-        mode: LaunchMode.platformDefault,
+        mode: LaunchMode.inAppBrowserView,
       ));
     });
 

diff --git a/test/widgets/theme_test.dart b/test/widgets/theme_test.dart
@@ -125,7 +125,7 @@ void main() {
   group('colorSwatchFor', () {
     const baseColor = 0xff76ce90;
 
-    testWidgets('light–dark animation', (tester) async {
+    testWidgets('light-dark animation', (tester) async {
       addTearDown(testBinding.reset);
 
       final subscription = eg.subscription(eg.stream(), color: baseColor);
@@ -135,6 +135,7 @@ void main() {
 
       await tester.pumpWidget(const TestZulipApp());
       await tester.pump();
+      await tester.pump();
 
       final element = tester.element(find.byType(Placeholder));
       // Compares all the swatch's members; see [ColorSwatch]'s `operator ==`.