Issue 629 - Use gt operator instead of max for highest row #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an operator is significantly faster than calling the max function. As this method is called more than once per cell the difference adds up.
guillaume-ro-fr
pushed a commit
to guillaume-ro-fr/PhpSpreadsheet
that referenced
this pull request
Jun 12, 2019
Using an operator is significantly faster than calling the max function. As this method is called more than once per cell the difference adds up. Closes PHPOffice#824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an operator is significantly faster than calling the max function.
As this method is called more than once per cell the difference adds up.
This is:
Checklist:
Why this change is needed?
When reading a large spreadsheet the
Worksheet::createNewCellmethod is called more times than the number of cells in the spreadsheet. When reading a ~100k cell spreadsheet I saw a 25% reduction in run time by replacing the call tomaxwith a>comparison.