Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 337 : Reader\Csv::inferSeparator() generates a notice when the file is empty #743

Closed
wants to merge 2 commits into from

Conversation

slaur
Copy link

@slaur slaur commented Oct 26, 2018

This is:

- [ x ] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

When loading an empty file with Reader\Csv, a notice is emitted because the inferSeparator() function tries to access an undefined array index. This can lead to an exception depending on your configuration.
Note that to detect the error in the first place, I changed the config to make phpunit fail on notices.

@PowerKiKi
Copy link
Member

PowerKiKi commented Oct 28, 2018

Thanks ! Merged in 79d86ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants