-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUMIFS with multiple conditions (fixes #704) #710
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cell's were summed multiple times if it matched several conditions whereas should only sum once
PowerKiKi
requested changes
Oct 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks like a good start. Unit tests are missing though. You should be able to add a few cases to cover your code in data/Calculation/MathTrig/SUMIF.php
Merged, thanks ! |
guillaume-ro-fr
pushed a commit
to guillaume-ro-fr/PhpSpreadsheet
that referenced
this pull request
Jun 12, 2019
Values were summed multiple times if it matched several conditions whereas it should only be summed once. Fixes PHPOffice#704 Fixes PHPOffice#710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cell's were summed multiple times if it matched several conditions whereas should only sum once
This is:
Checklist:
Why this change is needed?
If only one condition is provided, the range is summed correctly. If multiple conditions are provided the sum is inaccurate. It seems that a cell is summed multiple times if it matches the several conditions whereas it should only sum it once, even if matching several times.