add the DAYS() function #594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 11, 2018 17:31
The bug was reported by the scrutinizer here: https://scrutinizer-ci.com/g/PHPOffice/PhpSpreadsheet/inspections/225db0af-829f-4823-9591-efaade761da4/issues/files/src/PhpSpreadsheet/Calculation/DateTime.php?status=failed&conditionIds%5B0%5D=289959 The expression return PhpOffice\PhpSpre...tion\Functions::VALUE() returns the type string which is incompatible with the documented return type integer.
PowerKiKi
requested changes
Jul 15, 2018
| * | ||
| * @category Date/Time Functions | ||
| * | ||
| * @param mixed $endDate Excel date serial value (float), PHP date timestamp (integer), |
There was a problem hiding this comment.
type should enumerate all possibitilies here: \DateTime|int|float|string
| $startDate = Functions::flattenSingleValue($startDate); | ||
| $endDate = Functions::flattenSingleValue($endDate); | ||
|
|
||
| if (is_string($startDate = self::getDateValue($startDate))) { |
There was a problem hiding this comment.
Let's avoid assignment within condition and do it beforehand instead
| if (is_string($startDate = self::getDateValue($startDate))) { | ||
| return Functions::VALUE(); | ||
| } | ||
| if (is_string($endDate = self::getDateValue($endDate))) { |
| @@ -0,0 +1,89 @@ | |||
| <?php | |||
|
|
|||
There was a problem hiding this comment.
Tests cases miss a few cases for different input type such as DateTime, int and float
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
Merged in 2c981e4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DAYS() function
This is:
Checklist:
Why this change is needed?
The DAYS() function was not implemented so this PR adds it
Fixes #593