Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation/LookupRef.php - wrong function name _getMatrixDimensions #336

Closed
ArtemBro opened this issue Jan 12, 2018 · 1 comment
Closed

Calculation/LookupRef.php - wrong function name _getMatrixDimensions #336

ArtemBro opened this issue Jan 12, 2018 · 1 comment

Comments

@ArtemBro
Copy link

Hi!

Calculation/LookupRef.php contains function call Calculation::_getMatrixDimensions on lines 141 and 221,
but Calculation class has function getMatrixDimensions (without _) and it's private

//Same problem in PHPExcel 1.8.1
@PowerKiKi
Copy link
Member

thanks for reporting

@PowerKiKi PowerKiKi mentioned this issue Jan 18, 2018
Closed
PowerKiKi added a commit that referenced this issue Jan 28, 2018
@PowerKiKi
1.1.0
a2771e5 
- Support for PHP 7.2
- Support cell comments in HTML writer and reader - [#308](#308)
- Option to stop at a conditional styling, if it matches (only XLSX format) - [#292](#292)
- Support for line width for data series when rendering Xlsx - [#329](#329)

- Better auto-detection of CSV separators - [#305](#305)
- Support for shape style ending with `;` - [#304](#304)
- Freeze Panes takes wrong coordinates for XLSX - [#322](#322)
- `COLUMNS` and `ROWS` functions crashed in some cases - [#336](#336)
- Support XML file without styles - [#331](#331)
- Cell coordinates which are already a range cause an exception [#319](#319)
Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this issue Nov 20, 2018
@PowerKiKi
COLUMNS and ROWS functions crashed in some cases
08c0139 
Fixes PHPOffice#336
Fixes PHPOffice/PHPExcel#1383
Dfred pushed a commit to Dfred/PhpSpreadsheet that referenced this issue Nov 20, 2018
@PowerKiKi
1.1.0
81258ef 
- Support for PHP 7.2
- Support cell comments in HTML writer and reader - [PHPOffice#308](PHPOffice#308)
- Option to stop at a conditional styling, if it matches (only XLSX format) - [PHPOffice#292](PHPOffice#292)
- Support for line width for data series when rendering Xlsx - [PHPOffice#329](PHPOffice#329)

- Better auto-detection of CSV separators - [PHPOffice#305](PHPOffice#305)
- Support for shape style ending with `;` - [PHPOffice#304](PHPOffice#304)
- Freeze Panes takes wrong coordinates for XLSX - [PHPOffice#322](PHPOffice#322)
- `COLUMNS` and `ROWS` functions crashed in some cases - [PHPOffice#336](PHPOffice#336)
- Support XML file without styles - [PHPOffice#331](PHPOffice#331)
- Cell coordinates which are already a range cause an exception [PHPOffice#319](PHPOffice#319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PowerKiKi @ArtemBro