Created new configurations to optional TokenBlacklistedException #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a new config key to enable the blacklisted exception. - Updated unit tests.
eschricker
reviewed
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As been related on the forked repository (the first one) #2002, #457, #988, #1573, #983 (this is still open by the way), and in Laravel's application the TokenBlacklistedException shows just because we log out.
Even setting up the grace period to 30 still having the same issue, so I believe the TokenBlacklistedException should be optional since if someone is logged out, forced to log out, or even blacklisted for us (or by application) the exception most of the cases doesn't seem quite relevant to us to see.
This pull request it's a proposal to make this exception just be throwable by option.
Fixes:
PHP Unit tests running normally:
