Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't show jwt secret if show option is false even if the key is updated #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

don't show jwt secret if show option is false even if the key is updated #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ You can find and compare releases at the GitHub release page.
### Fixed
- Fixes #259 - Can't logout with an expired token
- Fixed #271 - Changing JWT_TTL in .env doesn't work
- Fixes #274 - Do not display jwt secret on console after successfully generated a new key

### Added
- Add `cookie_key_name` config to customize cookie name for authentication
Expand Down
2 changes: 1 addition & 1 deletion src/Console/JWTGenerateSecretCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public function handle()

if ($updated) {
$this->updateEnvEntry('JWT_ALGO', 'HS256');
$this->displayKey($key);
$this->info('jwt-auth secret set successfully.');
}
}

Expand Down