-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config to set auth cookie key name #266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good. I'll just wait for one more approval and merge it. Thanks @leoralph for your contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general LGTM but I've two concerns I'm sharing here
@mfn Thanks for the review, I have applied the fixes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👌🏼
Description
Currently, we can use cookies to send the auth token, but it is not documented and we cannot customize the cookie name.
This PR adds the
cookie_key_name
config to let us change the auth token cookie and adds documentation to the cookie authentication method.Checklist:
CHANGELOG.md