Cater for both Carbon v2 and v3 - issue #260 #261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carbon v3 deprecates the "diff real" functions, and throws a deprecated. It automatically routes the request to the function it thinks best, which in this case is
diffInRealMinutes
(see Carbon\Traits\Date::callDiffAlias() for details on why).Since we are aiming to support both, I split the code into a conditional, calling the appropriate function. It also now returns a float, so it's necessary to cast round result to int - as it too will return a float.
I also added a test pipeline specifically for carbon 3, since nothing requires it specifically right now.
Description
Fixes #260
Checklist:
CHANGELOG.md