Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #258 whereby logout fails if the JWT already being used has exp… #259

Merged
merged 4 commits into from
Jul 25, 2024
Merged

Fixes #258 whereby logout fails if the JWT already being used has exp… #259

merged 4 commits into from
Jul 25, 2024

Conversation

specialtactics
Copy link
Member

@specialtactics specialtactics commented Jul 16, 2024 •
edited
Loading

Description

Fixes #258 by catching our exceptions on token invalidation and proceeding with framework logout.

Checklist:

  • I've added tests for my changes or tests are not applicable
  • I've changed documentations or changes are not required
  • I've added my changes to CHANGELOG.md

@specialtactics specialtactics added the bug Something isn't working label Jul 16, 2024
@specialtactics specialtactics requested a review from Messhias July 25, 2024 06:39
Messhias
Messhias approved these changes Jul 25, 2024
View reviewed changes
Copy link
Collaborator

@Messhias Messhias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At home I'll merge it and publish it.

@Messhias Messhias merged commit c2b0aa7 into main Jul 25, 2024
12 checks passed
@Messhias Messhias deleted the bugfix/258-logout-with-expired-token branch July 25, 2024 06:42
@specialtactics
Copy link
Member Author

Awesome thanks @Messhias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Messhias Messhias Messhias approved these changes

@eschricker eschricker Awaiting requested review from eschricker

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If the application happens to be using an expired JWT, the logout operation causes an exception
2 participants
@specialtactics @Messhias