chore: update phpunit and misc maintenance #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka remove 9.4
Otherwise, with stability=prefer-lowest we would get this phpunit warning: ``` There were 2 PHPUnit warnings: 1) Test results may not be as expected because the XML configuration file did not pass validation: Line 26: - Element 'source': This element is not expected. 2) No filter is configured, code coverage will not be processed ``` Seems this was fixed in later releases.
Messhias
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR only touches test infrastructure, no library code!
we need to keep phpunit 10.5 for the lowest PHP/Laravel combination
Note: must be minimum 10.5 otherwise it emits XML validation warnings which apparently have been fixed in later releases
@testannotations and just use thetest*prefixtest*As of now, all matrix job where running coverage for no reason
matrix.os, was always the same value 🤷🏼Lastly, I changed the job names from:
to
It may not look as pretty but you can finally see all the variables.
Yeah, I maybe went a bit overboard but sometimes it hard to stop :) Also: since I only touched tests and everything is "green", it's low-to-no risk.
Checklist:
I've changed documentations or changes are not requiredI've added my changes toCHANGELOG.md