Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rector #237

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Remove rector #237

merged 1 commit into from
Mar 17, 2024

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Mar 17, 2024

Summary

I mentioned this already in the past in issues and wherenot that I suggest we remove rector as a dependency:

  • it was used as a "one time thing" to upgrade the code to PHP 7.4
  • it's not included in any CI workflow
  • it's an old version and conflicts with other packages
    Random example: with Laravel 11 it never installed L11 locally because of dependencies of rector conflicting with other L11 dependencies, always downgrading it to L10

Of course an alternate approach could be change all of the points I raised above, but since it's introduction no one cared and with L11 we actually had to work around it, so I propose we remove it for now. If someone later wants to make a more maintained integration, so be it.

@Messhias Messhias merged commit 79391c0 into PHP-Open-Source-Saver:main Mar 17, 2024
29 checks passed
@mfn mfn deleted the mfn-remove-rector branch March 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants