Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc. Github Action warning #232

Merged
merged 5 commits into from
Feb 21, 2024

Conversation

mfn
Copy link
Contributor

@mfn mfn commented Feb 21, 2024

Summary

Some of the the referenced actions are already quite outdated and cause a lot of warnings emmited if you check the workflow runs:

Notes

  • About the php-cs-fixer commit: this is unrelated to my changes, it simply wasn't run in a long time and php-cs-fixer evolved and therefore applies these changes.
  • They are still warnings emmited, but they're of different nature:
    image

mfn and others added 3 commits February 21, 2024 09:10
Fixes:
> `Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.`
Fixes:
> `The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
@mfn mfn marked this pull request as ready for review February 21, 2024 08:25
Fixes
> `Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.`
@mfn mfn force-pushed the mfn-gha-warnings branch from d36c466 to 6e1cd23 Compare February 21, 2024 08:26
Fixes
> `The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/`
@@ -24,12 +24,12 @@ jobs:

- name: Determine composer cache directory
id: composer-cache
run: echo "::set-output name=directory::$(composer config cache-dir)"
run: echo "dir=$(composer config cache-dir)" >> $GITHUB_OUTPUT
Copy link
Contributor Author

@mfn mfn Feb 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also changed directory to dir: streamlined in this repo and with online examples usually found

@mfn mfn mentioned this pull request Feb 21, 2024
@Messhias
Copy link
Collaborator

@mfn looks very good/nice to me. If you feel good about it I can merge it this weekend.

Thanks :)

@mfn
Copy link
Contributor Author

mfn commented Feb 21, 2024

The tests are green, you can merge immediately :)

@Messhias Messhias merged commit 4f1c757 into PHP-Open-Source-Saver:main Feb 21, 2024
27 checks passed
@mfn mfn mentioned this pull request Feb 21, 2024
@mfn mfn deleted the mfn-gha-warnings branch February 21, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants