-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misc. Github Action warning #232
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: > `Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.`
Fixes: > `The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`
Fixes > `Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/cache@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.`
mfn
force-pushed
the
mfn-gha-warnings
branch
from
February 21, 2024 08:26
d36c466
to
6e1cd23
Compare
Fixes > `The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/`
mfn
commented
Feb 21, 2024
@@ -24,12 +24,12 @@ jobs: | |||
|
|||
- name: Determine composer cache directory | |||
id: composer-cache | |||
run: echo "::set-output name=directory::$(composer config cache-dir)" | |||
run: echo "dir=$(composer config cache-dir)" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changed directory
to dir
: streamlined in this repo and with online examples usually found
Closed
Messhias
approved these changes
Feb 21, 2024
@mfn looks very good/nice to me. If you feel good about it I can merge it this weekend. Thanks :) |
The tests are green, you can merge immediately :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the the referenced actions are already quite outdated and cause a lot of warnings emmited if you check the workflow runs:
bump actions/cache
Fixes:
replace set-output with GITHUB_OUTPUT
Fixes:
bump codecov/codecov-action
Fixes
I checked the workflow and upload works, see https://github.com/PHP-Open-Source-Saver/jwt-auth/actions/runs/7986070882/job/21805731559?pr=232#step:11:50
bump actions/checkout
Fixes
Notes