Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of SearchCondition with other Conditions in Elasticsearch and Opensearch #314

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Fix usage of SearchCondition with other Conditions in Elasticsearch and Opensearch #314

merged 8 commits into from
Dec 13, 2023

Conversation

dhirtzbruch
Copy link
Contributor

@dhirtzbruch dhirtzbruch commented Dec 12, 2023 •
edited
Loading

Should IMHO fix issue #313

@alexander-schranz alexander-schranz added the bug Something isn't working label Dec 12, 2023
@dhirtzbruch dhirtzbruch marked this pull request as draft December 13, 2023 05:15
@alexander-schranz
Copy link
Member

Looks like the same issue appears on Opensearch can you implement the same mechanism on that Adapter? The Lint should be fixable via php-cs-fixer you can run it via composer fix command.

@dhirtzbruch
Copy link
Contributor Author

@alexander-schranz Any idea why the opensearch test keeps failing in Github action? It works on my machine... ;-)

@dhirtzbruch dhirtzbruch marked this pull request as ready for review December 13, 2023 12:34
@alexander-schranz alexander-schranz changed the title Combine SearchCondition and EqualCondition resulting in erroneous ELS request Fix combination of SearchCondition and EqualCondition in Elasticsearch and Opensearch Dec 13, 2023
@alexander-schranz alexander-schranz added Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue labels Dec 13, 2023
@alexander-schranz
Copy link
Member

alexander-schranz commented Dec 13, 2023 •
edited
Loading

Any idea why the opensearch test keeps failing in Github action? It works on my machine... ;-)

It sadly a race condition problem of Github CI not cloning the correct commit, you can ignore it as long as locally the issues are fixed.

@dhirtzbruch
Copy link
Contributor Author

Oh, thanks - then it's working from my point of view.

@alexander-schranz alexander-schranz changed the title Fix combination of SearchCondition and EqualCondition in Elasticsearch and Opensearch Fix usage of SearchCondition with other Coniditions in Elasticsearch and Opensearch Dec 13, 2023
@alexander-schranz alexander-schranz changed the title Fix usage of SearchCondition with other Coniditions in Elasticsearch and Opensearch Fix usage of SearchCondition with other Conditions in Elasticsearch and Opensearch Dec 13, 2023
@alexander-schranz alexander-schranz merged commit efa54fa into PHP-CMSIG:0.2 Dec 13, 2023
27 of 32 checks passed
@alexander-schranz
Copy link
Member

@dhirtzbruch Thank you for the test and fix, good work 👍

@alexander-schranz alexander-schranz mentioned this pull request Dec 13, 2023
Closed
@dhirtzbruch dhirtzbruch deleted the issue-313 branch December 15, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Adapter: Elasticsearch Elasticsearch Adapter releated issue Adapter: Opensearch Opensearch Adapter related issue bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhirtzbruch @alexander-schranz