Added new settings with functionality #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dded setting for auto-adjusting input toolbar to keyboard
pgs-dkanak
suggested changes
Apr 13, 2017
Demo/ViewController.swift
Outdated
| @@ -72,7 +72,7 @@ extension ViewController: MessagesViewDelegate { | |||
| func didTapRightButton() { | |||
| let text = messagesView.inputText | |||
| TestData.exampleMessageText.append(text) | |||
| messagesView.refresh() | |||
| messagesView.refresh(scrollDown: true) | |||
There was a problem hiding this comment.
There is a setting for this feature: MessagesViewSettings::textInputScrollsToRecentMessage, and this one should be used and/or renamed if needed. My proposal is: scrollsToLastMessage.
…fixed keyboard vertical adjustment, fixed collectionView bottom scroll indicator inset, lower Deployment Target to enable iPhone 4s, added public scrollToLastMessage function
…or their disabled state
pgs-dkanak
suggested changes
Apr 18, 2017
MessagesView/MessagesView.swift
Outdated
| public var delegate : MessagesViewDelegate? | ||
| public var dataSource: MessagesViewDataSource? | ||
|
|
||
| //NARK:- |
pgs-dkanak
approved these changes
Apr 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setting for auto-scrolling down when refreshing message view, a…dded setting for auto-adjusting input toolbar to keyboard