Feature/dk/kil 84 custom message bubbles #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added separator line Added image for demo
Added custom bubbles Added bubbles ordering Added bubble-specific margins calculation Added external settings interface to set custom bubbles
bdudarPGS
reviewed
Apr 13, 2017
MessagesView/BubbleImage.swift
Outdated
| return nil | ||
| } | ||
|
|
||
| private func cropAndResize(slice: ImageSlice)->UIImage { |
There was a problem hiding this comment.
We can get rid of some code duplication and optionals. Try:
private func cropAndResize(slice: ImageSlice?) -> UIImage {
guard let slice = slice, let croppedImage = image.cgImage?.cropping(to: slice.cropRect) else {
return UIImage()
}
return UIImage(cgImage: croppedImage).resizableImage(withCapInsets: slice.resizeInsets, resizingMode: .stretch).withRenderingMode(.alwaysTemplate)
}
and then:
lazy var whole: UIImage = self.cropAndResize(slice: self.wholeSlice)
lazy var top: UIImage = self.cropAndResize(slice: self.topSlice)
lazy var middle: UIImage = self.cropAndResize(slice: self.middleSlice)
lazy var bottom: UIImage = self.cropAndResize(slice: self.bottomSlice)
bdudarPGS
reviewed
Apr 13, 2017
| import Foundation | ||
|
|
||
| class MessagesGroupingCoordinator { | ||
| public func selectBackgroundFor(index: Int, inMessages messages: [MessagesViewChatMessage], withBubble bubbbleImage: BubbleImage)->UIImage { |
There was a problem hiding this comment.
This function can be moved to MessageView, no need for separate class with no properties.
There was a problem hiding this comment.
This is done this way due to predictability of different grouping styles available in future. If there will be any, we will simply add new grouping coordinator object. Conversely there is no need to put it in another class if we got only one way of grouping messages. For now however, this way of embedding this functionality is just a mark that grouping criteria might change in the future.
Removed MessagesGroupingCoordinator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom message bubbles configuration with message grouping