Reconstruct source code for FACTOR. #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd probably put it in sysen3, under the premise that this is not a very critical piece of software. That's where we've been putting some of the random sources for programs where we weren't sure what the correct sysenX directory was. |
This is based on a disassembly of the binary AI:SYS1;TS FACTOR; the binary and its help file .INFO.;FACTOR ORDER are both dated 1977-09-27. MC had an identical copy with a later date. This assembles into a binary that's identical to the original, except that the original version has all its symbols marked as global, and no assembly info. Fixes #96.
|
Sounds good; moved to src/sysen3. |
eswenson1
approved these changes
Mar 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a disassembly, so any misunderstandings in the comments are my own fault.
It turns out that this uses a straightforward trial division approach, although it has a couple of neat tricks to speed up its inner loop. To be fair, most of the better factoring algorithms we'd use today hadn't been invented in 1977.
I've put the reconstructed source in src/sysen1, but that's a fairly arbitrary choice; any better suggestions?
Fixes #96.