chore: polishing tiles config + add extra linting (more golangci-linters + hadolint) #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kad-korpem
approved these changes
Jan 6, 2025
kad-dirc
reviewed
Jan 6, 2025
| @@ -19,7 +19,7 @@ ENV GOOS=linux | |||
| # install sqlite-related compile-time dependencies | |||
| RUN set -eux && \ | |||
| apt-get update && \ | |||
| apt-get install -y libcurl4-openssl-dev libssl-dev libsqlite3-mod-spatialite && \ | |||
| apt-get install --no-install-recommends -y libcurl4-openssl-dev=* libssl-dev=* libsqlite3-mod-spatialite=* && \ | |||
There was a problem hiding this comment.
Die hadolint is een mooie aanvulling, kunnen we voor meer projecten gebruiken.
Ik vind de "=*" alleen niet zo veel toevoegen. Misschien willen we rule DL3008 disabelen?
There was a problem hiding this comment.
Ja die regel uitzetten kan ook idd. Voor mij om het even. Opzich leek mij dit ook en heldere oplossing. Snap het idee om versions te pinnen maar we willen juist ook up to date zijn en ik verwacht ook niet snel breaking issues met curl/openssl/spatialite.
En idd +1 om vaker hadolint te gebruiken.
kad-dirc
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
polishing tiles config + add extra linting (more golangci-linters + hadolint). Also fixes e2e test failure.
Type of change
Checklist: