Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for https://github.com/PDOK/gokoala/pull/263 to also support collection IDs with quotes #269

Merged
merged 4 commits into from
Dec 31, 2024
Merged

fix: for https://github.com/PDOK/gokoala/pull/263 to also support collection IDs with quotes #269

merged 4 commits into from
Dec 31, 2024

Conversation

rkettelerij
Copy link
Collaborator

Description

Followup fix for #263

Type of change

  • Bugfix

Checklist:

  • I've double-checked the code in this PR myself
  • I've left the code better than before (boy scout rule)
  • The code is readable, comments are added that explain hard or non-obvious parts.
  • I've expanded/improved the (unit) tests, when applicable
  • I've run (unit) tests that prove my solution works
  • There's no sensitive information like credentials in my PR

@rkettelerij rkettelerij merged commit 35d1dff into master Dec 31, 2024
4 of 5 checks passed
@rkettelerij rkettelerij deleted the support-quotes-in-collection-ids branch December 31, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerdos82 gerdos82 gerdos82 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkettelerij @gerdos82