Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFS Carbon/ProStreet: Correct the serial the game uses to detect Most Wanted Black Edition saves #499

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

CookiePLMonster
Copy link
Contributor

@CookiePLMonster CookiePLMonster commented Feb 22, 2025

Please merge together with PCSX2/pcsx2#12340.

Fixes an old bug where only base Most Wanted saves granted the cash bonus, and MW Black Edition saves did not. This is because the game used an incorrect serial to detect BE saves.

image

ProStreet is seemingly unaffected, as it detects Most Wanted, Most Wanted BE, Carbon, Carbon CE correctly.

@CookiePLMonster
Copy link
Contributor Author

Added PAL Carbon and Carbon Collector's Edition. The fix was more involved here since the function returning the MW BE serial returned NULL, thankfully there was enough space around the function to fit in a proper serial check (SLES-53857).

@CookiePLMonster CookiePLMonster marked this pull request as ready for review February 22, 2025 18:33
@CookiePLMonster CookiePLMonster changed the title NFS Carbon: Correct the serial the game uses to detect Most Wanted Black Edition saves NFS Carbon/ProStreet: Correct the serial the game uses to detect Most Wanted Black Edition saves Feb 22, 2025
@CookiePLMonster CookiePLMonster force-pushed the carbon-save-detection-fix branch from 3fde7d6 to 64e8a38 Compare February 22, 2025 22:10
@CookiePLMonster
Copy link
Contributor Author

Turns out PAL ProStreet needs that fix too. Also ported the native widescreen toggle from NTSC-U while at it:

Need for Speed - ProStreet_SLES-55002_20250222230323

… Wanted Black Edition saves

Fixes an old bug where only base Most Wanted saves granted
the cash bonus, and MW Black Edition saves did not.
This is because the game used an incorrect serial to detect
BE saves in NTSC-U, and no serial in PAL.
PAL ProStreet was also affected.
@CookiePLMonster CookiePLMonster force-pushed the carbon-save-detection-fix branch from 64e8a38 to 26f21df Compare February 23, 2025 10:43
@CookiePLMonster
Copy link
Contributor Author

Added support for SLES-55006.

@F0bes F0bes merged commit 7c2d5cb into PCSX2:main Feb 24, 2025
3 checks passed
@CookiePLMonster CookiePLMonster deleted the carbon-save-detection-fix branch February 24, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants