Change READ_CHAR_MAX to maximum unsigned value #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix range computation when xclass is NOT in eclass.
|
I don't understand the implications of this. Did it affect the 32-bit library? |
|
No. It was wrongly defined (probably to fit to an int), but it was harmless since there is no optimization for characters > 0x7fffffff. However it is better this way. |
zherczeg
commented
Dec 7, 2024
| @@ -639,7 +639,7 @@ if (category_list == UCPCAT_ALL) | |||
| if (*cc != XCL_END) | |||
| { | |||
| #if defined SUPPORT_UNICODE && (PCRE2_CODE_UNIT_WIDTH == 8 || PCRE2_CODE_UNIT_WIDTH == 16) | |||
| if (common->utf && compares == 0 && (status & XCLASS_IS_ECLASS)) | |||
| if (common->utf && compares == 0 && !(status & XCLASS_IS_ECLASS)) | |||
There was a problem hiding this comment.
It was a typo. Luckily, it has no other effect than a deoptimization (xclass case is not optimized, the eclass case always ignored the computed value). Fortunately I noticed it.
NWilson
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just one line change, but I want to make sure it does not break anything.