Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install and test zlib, bzip2 in CI builds #582

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

NWilson
Copy link
Member

@NWilson NWilson commented Nov 26, 2024

Also, ensure that the libreadline and libeditline builds pass (although we can't really test whether these work).

@NWilson NWilson force-pushed the user/niwilson/ci-zlib branch 2 times, most recently from 7265b20 to 2d7a23f Compare November 26, 2024 11:29
Copy link
Contributor

@carenas carenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use editline in the alpine job for variety?

not sure why this is needed though (maybe something to add to the commit message on the rationale), since the test should work regardless and it is mostly useful when the tool is used interactively

@@ -16,7 +21,7 @@ jobs:
run: ./autogen.sh

- name: Configure
run: ./configure --enable-jit --enable-pcre2-16 --enable-pcre2-32
run: ./configure --enable-jit --enable-pcre2-16 --enable-pcre2-32 --enable-pcre2grep-libz --enable-pcre2grep-libbz2 --enable-pcre2test-libreadline
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also have libeditline support (which is preferred due to license in the BSD)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I can use that.

I really wanted the CI to be testing the zlib/bzip2 support; and when I added that, I thought it would be reasonable to throw in a test for readline too (although we're only testing it builds & links, and not really exercising the readline support).

The readline support is not really important, since it's just test-only. It would be OK if it broke. But the zlib support can't break.

Copy link
Contributor

@carenas carenas Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truth is that pcre2grep was always treated as a more complicated version of pcre2demo, and that is the only tool that needs the dependency (the library does not)

agree though we are better off testing and treating it more like a product, as it seems people seem to think it is almost as useful as GNU grep of ripgrep (which funny enough also uses PCRE2)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nicer if other people could maintain the frontend (like even GNU grep has -P now for PCRE!)

But I guess if people are using pcre2grep, then it needs to be tested.

I'm happy with this PR. We only need a minimal effort (smoke test) to exercise these external library integrations.

@NWilson NWilson force-pushed the user/niwilson/ci-zlib branch from 2d7a23f to a3b4474 Compare November 26, 2024 13:46
@NWilson NWilson changed the title Install zlib in CI builds Install and test zlib, bzip2 in CI builds Nov 26, 2024
@NWilson NWilson force-pushed the user/niwilson/ci-zlib branch from a3b4474 to b921a29 Compare November 26, 2024 13:52
Also, ensure that the libreadline and libeditline builds pass (although
we can't really test whether these work).
@NWilson NWilson force-pushed the user/niwilson/ci-zlib branch from b921a29 to 4fc784d Compare November 26, 2024 13:56
Copy link
Collaborator

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zherczeg zherczeg merged commit 3f01c33 into PCRE2Project:master Nov 27, 2024
21 checks passed
@NWilson NWilson deleted the user/niwilson/ci-zlib branch December 17, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants