Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup.py #881

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Update setup.py #881

merged 4 commits into from
Oct 20, 2022

Conversation

lee1043
Copy link
Contributor

@lee1043 lee1043 commented Oct 19, 2022

In setup.py:
(1) Exclude cmec and tests directories from package finding, to address #858.
(2) Remove not-in-use files (old demo, png, vcs-related).
(3) Clean up

#858. (2) Remove not-in-use files (old demo, png, vcs-related). (3) Clean up
@lee1043 lee1043 requested a review from acordonez October 19, 2022 19:05
@lee1043 lee1043 linked an issue Oct 19, 2022 that may be closed by this pull request
@acordonez
Copy link
Collaborator

@lee1043 The installation seems to work fine using python setup.py install, but I'm not sure how to tell if the unwanted files are not being included.

@lee1043
Copy link
Contributor Author

lee1043 commented Oct 19, 2022

@acordonez thanks for checking the installation. I think that is fine for now. I don't think there is a way to check what's in conda-released tar file until we tag new version and release it.

@lee1043 lee1043 merged commit 14d811d into main Oct 20, 2022
@lee1043 lee1043 deleted the 858_ljw_package branch October 20, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmec and tests directories are being included in python package
2 participants