Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission documentation #22

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Conversation

offa
Copy link
Contributor

@offa offa commented Jul 1, 2021

Permission documentation added.

Todo: What's ACCESS_NETWORK_STATE used for?

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of changes

Document permission required.

Fixes the following issues

/

Any additional information

/

APK testing

/

Due Diligence

@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jul 1, 2021

AFAIK, ACCESS_NETWORK_STATE is requested by ExoPlayer's online functionality. I don't use it [Auxio is 100% offline], and I believe its mandatory.

@OxygenCobalt OxygenCobalt requested review from OxygenCobalt and removed request for OxygenCobalt July 1, 2021 21:14
@offa
Copy link
Contributor Author

offa commented Jul 2, 2021

There's a related issue here: google/ExoPlayer#6019

It seems possible to revoke the permission by manifest (example included in the issue).

OxygenCobalt added a commit that referenced this pull request Jul 2, 2021
ExoPlayer's online functionality will cause the library to request the
ACCESS_NETWORK_STATE permission. We don't need this since we use
ExoPlayer for local playback only. For simplicity [and to remove a
weird suspicious permission, we just disable it]
@OxygenCobalt
Copy link
Owner

OxygenCobalt commented Jul 2, 2021

I applied that trick and it seems to work. I'll push a commit removing the ACCESS_NETWORK_STATE perm from the in-progress README.

Remove ACCESS_NETWORK_STATE from the README document, as it was
disabled in f1f2fcf.
@offa
Copy link
Contributor Author

offa commented Jul 2, 2021

Nice! 👍

@OxygenCobalt OxygenCobalt merged commit eca8a99 into OxygenCobalt:dev Jul 2, 2021
@offa offa deleted the permission_doc branch July 2, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants