-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add exclusions for absolute URLs #35
add exclusions for absolute URLs #35
Conversation
Thanks for taking a look at this. As you can probably guess, I haven't really been maintaining this repo for a while now. I think this is an interesting idea, but I have a couple requests:
|
Thanks for taking a look and happy to make the suggested changes.
fair point, but happy that this can be considered a feature of the tool 😄 regarding this part
To implement that, would you like it so the user just passes something like processInput({
files: ['**/*.js', '**/*.png', '**/*.css'],
defaultCDNBase: '//examplecdn/',
preserveAbsolute: true
}, 'index-exclusions.html', 'index-exclusions.html'); and then the tool would only enable that check if the flag is in place? var cdnTemplate = preserveAbsolute && excludeCdnPrefix
? '<%= filepath %>'
: fileInfo.cdn || opts.defaultCDN; I can update the README as well if the above behavior documented. |
Yeah, exactly! And if you would update the README, that would be great, too. Thanks a bunch! |
@OverZealous |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
clarify test case refactor fix formatting fix formatting fix formatting fix formatting enable feature as an opt-in flag and document grammar grammar grammar
d816251
to
e40afa4
Compare
@OverZealous |
Published as v3.1.0 |
resolves #21 by adding exceptions for paths that wouldn't need cdnizing, like:
//cdn.com/lib/index.js
http[s]://cdn.com/lib/index.js