Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added interval support #18

Merged
merged 5 commits into from
Dec 12, 2019
Merged

added interval support #18

merged 5 commits into from
Dec 12, 2019

Conversation

CruelMoney
Copy link
Contributor

I needed to use a smaller interval than a day, and added the option to use an hourly interval.
Could be made more versatile.

@scerelli
Copy link
Contributor

scerelli commented Oct 3, 2019

thanks @CruelMoney
are you planning to implement also the android part?

@CruelMoney
Copy link
Contributor Author

thanks @CruelMoney
are you planning to implement also the android part?

Yes, probably within a month.

@scerelli
Copy link
Contributor

scerelli commented Oct 4, 2019

ok so let's keep this open until it's finished

@scerelli
Copy link
Contributor

scerelli commented Dec 6, 2019

seems good to me, @CruelMoney if you fix the conflicts i think we can merge this.

cc @Francesco-Voto let me know if these changes are ok for you so i can test it on some devices

Copy link
Contributor

@scerelli scerelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add few lines to the readme to point out this change

@CruelMoney
Copy link
Contributor Author

Just finished the android implementation and added details to the readme. How does it look?

@scerelli
Copy link
Contributor

@CruelMoney looks good to me i'm gonna merge this

@scerelli scerelli merged commit 69e8823 into OvalMoney:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants