add RequestMetricsBuilder.with_metric_attrs_from_req #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a builder method
with_metric_attrs_from_req
that accepts a function to generate metric attributes from the request. Function has the same signature with and by default isutil::metrics_attributes_from_request
. Also exposingmetrics_attributes_from_request
since whoever wants to add additional attributes may want to reuse it and extend its result.Fixes #171