Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python3.13 #2054

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Support Python3.13 #2054

wants to merge 5 commits into from

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 20, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGELOG.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Adds a Python3.13 build to the CI
  • Removes the sphinx-codeautolink/pygments workarounds

Does this PR introduce a breaking change?

No, but once this is passing, we should prepare to drop support for Python3.10. This is mentioned in CHANGELOG.rst.

Other information:

numba v0.61.0 was released earlier today: https://numba.readthedocs.io/en/stable/release/0.61.0-notes.html

I needed to add a Coveralls-based action step because the Python package for Coveralls still doesn't support Python3.13 (see: TheKevJames/coveralls-python#523)

…k workarounds

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre requested a review from a team January 20, 2025 17:24
@Zeitsperre Zeitsperre self-assigned this Jan 20, 2025
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2025.1.8).

No further action is required.

@github-actions github-actions bot added the CI Automation and Contiunous Integration label Jan 20, 2025
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre Zeitsperre added the approved Approved for additional tests label Jan 20, 2025
Copy link
Collaborator Author

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this trigger the advanced tests? Let's see.

It does. nice.

Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
Signed-off-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@Zeitsperre
Copy link
Collaborator Author

Zeitsperre commented Jan 20, 2025

It looks as though there are changes to the ways that docstrings are parsed in Python3.13: https://docs.python.org/3.13/whatsnew/3.13.html#other-language-changes

This is breaking a lot of docstring tests. Will see what I can do.

Update: This looks like it's going to be complicated. Here's the PR that added the changes: python/cpython#81283

@Zeitsperre Zeitsperre marked this pull request as draft January 20, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for numpy 2.0 and Python 3.13
1 participant