Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy option #70

Closed
mehti1367 opened this issue Dec 7, 2018 · 12 comments
Closed

Add proxy option #70

mehti1367 opened this issue Dec 7, 2018 · 12 comments
Assignees
Labels
feature-request New feature or request

Comments

@mehti1367
Copy link

mehti1367 commented Dec 7, 2018

Hi there, I'm living in a country which banned bandcamp website, it would be nice you guys add proxy option (sock5) to it thanks...

@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

Hi,

deezer

This app is for Bandcamp only.

@mehti1367
Copy link
Author

sorry that's typo

@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

BandcampDownloader already supports the system proxy. Did you try setting a proxy in Windows settings?

@mehti1367
Copy link
Author

Excuse me what are you mean system proxy?I just seen a "Save current setting" button, I'm using Tor Bundler Proxy which means an internal proxy to use it on another apps, it's not tunnel all internet traffic like VPNs, I know if i use a VPN to tunnel all my traffic BandcampDowloader will works fine, But my goal is only tunnel BandcampDownloader if there is a option for that,The tor bundler gives a internal proxy like 127.0.0.1:9050, so inside the app must be an option to put that adress:port like every proxy over the internet.

@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

I meant this:

proxy screenshot

But this will redirect all traffic of your machine to your proxy, and from what you just said it doesn't seem to be what you want, right?

@mehti1367
Copy link
Author

mehti1367 commented Dec 7, 2018

I know this, I dont want tunnel all my traffic trough a proxy on LAN setting(As some of website out there need my actuall ip, it's really risky to me)

So if you mind, Add option that could handle external proxies, Most popluar app has this option like mozilla: https://malzo.com/i/2018/12/07/h5h.png

With this method, it is possible to use spcific proxy only on this app.

@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

Got it. I'll see what I can do. 👍

@mehti1367
Copy link
Author

Awesome! Note that it would be nice this option support all protocol like HTTP, Socks5, HTTPS etc...

@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

First version will be HTTP / SSL only.

SOCKS is a little more tricky...

Otiel added a commit that referenced this issue Dec 7, 2018
@Otiel Otiel self-assigned this Dec 7, 2018
@Otiel Otiel added the feature-request New feature or request label Dec 7, 2018
@Otiel
Copy link
Owner

Otiel commented Dec 7, 2018

Can you try the new version and let me know if it works with a HTTP proxy?

@mehti1367
Copy link
Author

mehti1367 commented Dec 8, 2018

Yeap. Works very well, See my screen record:

https://streamable.com/t16g9

Much Appreciated!

@Otiel
Copy link
Owner

Otiel commented Dec 8, 2018

Thanks for the feedback.

Closing this for now. I'll revisit the SOCKS option if there is more demand.

@Otiel Otiel closed this as completed Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants