Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log position reset when opening Settings (dark theme only) #112

Closed
Otiel opened this issue Jun 17, 2019 · 1 comment
Closed

Log position reset when opening Settings (dark theme only) #112

Otiel opened this issue Jun 17, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@Otiel
Copy link
Owner

Otiel commented Jun 17, 2019

Steps to reproduce

  1. Set theme to Dark.
  2. Start downloading so that the log contains more than the visible space.
  3. Scroll down.
  4. Open settings.

Actual results

  • The log position is reset to top.

Expected results

  • The log position shouldn't be reset.

Notes

  • This bug doesn't happen when the theme is set to Light.
@Otiel Otiel added the bug Something isn't working label Jun 17, 2019
@Otiel Otiel added this to the Next version milestone Aug 7, 2019
Otiel added a commit that referenced this issue Aug 7, 2019
@Otiel
fix: theme not changed when cycling back
04fc8b5 
Correctly fixes #112, fixes bug introduced in f67b1cf
@Otiel Otiel closed this as completed in f67b1cf Aug 7, 2019
@Otiel Otiel removed this from the Next version milestone Aug 7, 2019
@Otiel
Copy link
Owner Author

Otiel commented Aug 7, 2019

Fixed in 1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Otiel