Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #51

Merged
merged 7 commits into from
Jun 3, 2022
Merged

Update dependencies #51

merged 7 commits into from
Jun 3, 2022

Conversation

mathiaseitz
Copy link
Member

Fixes #50

@mathiaseitz mathiaseitz mentioned this pull request Jun 2, 2022
Closed
trendelkampschroer
trendelkampschroer reviewed Jun 3, 2022
View reviewed changes
Copy link
Contributor

@trendelkampschroer trendelkampschroer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a PR open with matching changes that never got a green light from CI, cf. #49. Did you change anything in the build pipeline in the meantime?

Travis CI does seem to hang also for your PR. If you understand how to FIX CI, could you rebase your PR on #49. Then we can merge in succession.

@mathiaseitz
Copy link
Member Author

@trendelkampschroer I am now working on getting Travis running again. Will ping you once this is done so we can merge your PR first.

@mathiaseitz mathiaseitz merged commit c219b9c into master Jun 3, 2022
@mathiaseitz mathiaseitz deleted the update-dependencies branch June 3, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trendelkampschroer trendelkampschroer trendelkampschroer left review comments

@ronaldrichter ronaldrichter ronaldrichter approved these changes

@markounikau markounikau markounikau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update dependencies
4 participants
@mathiaseitz @ronaldrichter @trendelkampschroer @markounikau