This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
[WIP] Add rclone support #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backmerge
…rts into add-Rclone-support
|
Definitely a major version bump will be needed, which isn't really an issue since we have done it a few times now. Definitely push that change so the testing passes. I'll take a look through the rest this afternoon. |
rjkernick
reviewed
Nov 19, 2020
| @@ -1,6 +1,6 @@ | |||
| apiVersion: v1 | |||
| name: sonatype-nexus | |||
| version: 3.6.0 | |||
| version: 4.0.0 | |||
| appVersion: 3.27.0 | |||
There was a problem hiding this comment.
Please also update the sources with the new backup container project
|
Please update the maintainer email in the image as well: https://github.com/dbccompany/docker-nexus-backup/blob/master/Dockerfile |
|
Failed linting on a couple things: charts/sonatype-nexus/values.yaml |
|
@rjkernick fixed |
rjkernick
approved these changes
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rjkernick !
We've prepared alternative docker-nexus-backup image with RClone tool in order to support a variety of cloud object stores as a backend for backup.
We tested it with AWS, so would be great if someone can re-test with GCE's GS and provide some feedback.
In addition to that, since the change is not backward compatible in values.yaml we have to consider major version bump, need your opinion on that @rjkernick
Please feel free to ping @MohamedZ3kri or @dene14, we really want to get that merged :)