This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rjkernick
suggested changes
Nov 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Any chance you could add to the CHANGELOG.md?
rjkernick
approved these changes
Nov 19, 2020
@rjkernick I've updated the CHANGELOG and also added a brief explanation into the README. |
Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've been reworking this chart to function in an OpenShift cluster. The changes look to do a number of things:
I've got it working on my OpenShift cluster with:
It runs postgreSQL under the default restricted SCC and creates the stripped-down "privileged" SCC for SonarQube.
SCC creation is invoked by using a new key in values.yaml (
OpenShift.enabled
) which asserts whether OpenShift SCC resources need to be created.I've also:
Just wanted to see if there is any interest in this, and any validation you'd like to apply.