This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Lazy tentative to replace of auto_ptr with unique_ptr and move to c++14 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add some std::move to please the compiler remove the c++98 flag in the main cmake script Testsuite (at least simply running ctest) works
|
"au temps pour moi" and thanks a lot @sloriot |
|
@sloriot Thanks ! |
Closed
lrineau
reviewed
Nov 6, 2019
| PreparedGeometry::PreparedGeometry( std::auto_ptr<Geometry> geometry, srid_t srid ) : | ||
| _geometry( geometry ), | ||
| PreparedGeometry::PreparedGeometry( std::unique_ptr<Geometry>&& geometry, srid_t srid ) : | ||
| _geometry( geometry.release() ), |
There was a problem hiding this comment.
When a function claims ownership of a pointer, the unique_ptr is best taken by value:
PreparedGeometry::PreparedGeometry( std::unique_ptr<Geometry> geometry, srid_t srid )
_geometry( std::move(geometry) ),For a long explanation, you can read https://stackoverflow.com/a/8114913/1728537.
The semantic of void f(std::unique_ptr<Geometry>&& geometry) is that f may take the ownership.
There was a problem hiding this comment.
I agree, passing rvalue references of unique_ptr seems very confusing to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not claiming this is perfect, but at least it compiles and the testsuite (simply running ctest) works.