Fix missing monster Challenge Ratings #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from Orcpub/orcpub/develop
codeGlaze
approved these changes
Jan 31, 2019
|
What is going on here? Clojure is byzantine, but this looks like all it does is filter out keys from the |
|
The change fixes the bug that only listed CRs that existed on pre-populated monsters. Which was not the entire CR range. |
|
Yes, that is exactly what it does. monsters5e/challenge-ratings has CR XP. I only needed the CR so it drops the XP. |
|
And only for pairs where there is an XP, if I read that correctly? |
|
pairs are defined here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41