Fix css lien figwheel #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea with the timeout, but why make it optional? I'd say set it to 2 minutes and make it enabled by default |
|
Ok 👍 |
Demonsthere
approved these changes
Jan 25, 2019
MeanderingCode
previously requested changes
Jan 25, 2019
|
So, what do we want to do here? Do we agree on removing auth for parts of code that are dedicated for figwheel, and set parameters in the parts used in uberjar? |
codeGlaze
approved these changes
Feb 5, 2019
It looks like the code in question was changed or explained properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description