Fixes #508 wand of the war mage missing bonuses #512
Conversation
WARNING: breaks existing name keys for the various Wands of the War Mage + Introduce new generic function for creating + Added some missing "action" blurbs + Fixes possible typo in `from-internal-item` properties + Automatic EOL changes to fit file format
| @@ -333,6 +334,25 @@ Additionally, you can focus your senses as an action to magically discern the di | |||
| direction to the closest dragon within 30 miles of you that is of the same type as the armor. This special action can’t be used again until the next dawn." | |||
| )}) | |||
|
|
|||
| (defn | |||
There was a problem hiding this comment.
There already is a spell-attack-modifier-bonus and a spell-save-dc-bonus in modifiers.cljc
Do they not provide the functionality your after?
They can be used like this:
::modifiers [(mod5e/spell-attack-modifier-bonus 2)
(mod5e/spell-save-dc-bonus 3)]
| @@ -2816,25 +2844,17 @@ The wand regains 1d6 + 1 expended charges daily at dawn. If you expend the wand | |||
| ::type :wand | |||
| ::rarity :uncommon | |||
| ::description "The wand has 3 charges. While holding it, you can use an action to expend 1 of its charges, and if a secret door or trap is within 30 feet of you, the wand pulses and points at the one nearest to you. The wand regains 1d3 expended charges daily at dawn." | |||
| }{ | |||
| name-key "Wand of the War Mage, +1" | ||
| ::type :wand | ||
| ::rarity :uncommon | ||
| ::attunement [:spellcaster] |
There was a problem hiding this comment.
::modifiers [(mod5e/spell-attack-modifier-bonus 1)
(mod5e/spell-save-dc-bonus 1)]
| name-key "Wand of the War Mage, +2" | ||
| ::type :wand | ||
| ::rarity :rare | ||
| ::attunement [:spellcaster] |
There was a problem hiding this comment.
::modifiers [(mod5e/spell-attack-modifier-bonus 2)
(mod5e/spell-save-dc-bonus 2)]
| name-key "Wand of the War Mage, +3" | ||
| ::type :wand | ||
| ::rarity :very-rare | ||
| ::attunement [:spellcaster] |
There was a problem hiding this comment.
::modifiers [(mod5e/spell-attack-modifier-bonus 3)
(mod5e/spell-save-dc-bonus 3)]
| ::attunement [:spellcaster] | ||
| ::description "While holding this wand, you gain a +3 bonus to spell attack rolls. In addition, you ignore half cover when making a spell attack." | ||
| }{ | ||
| } |
There was a problem hiding this comment.
and this whole section can be removed.
|
That's exactly what I did. I used those modifiers, just abstracted it to cut down boilerplate code and potentially reuse for other items/custom items in the future. |
Looks like this is moving away from the convention that is already in place across all the magic items for three items. I disagree with what he did with the I'm not apposed to introducing something like this - but imho it is the data set, probably should just follow that architecture - now if you want to update them all that's fine, but let's not just do 3. |
|
In https://dev.dungeonmastersvault.com for testing |
Description:
Related issue (if applicable): fixes #508
Wand of the War Mage was not applying the spell attack modifier.
WARNING: breaks existing name keys for the various Wands of the War Mage
Introduce new generic function for creating items (focused on caster bonuses but could be generic)
Added some missing "action" blurbs
Fixes possible typo in
from-internal-itempropertiesAutomatic EOL changes to fit file format
Checklist: