Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #503 [Bug] Email address validator doesn't comply with new TLD #504

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Fixes #503 [Bug] Email address validator doesn't comply with new TLD #504

merged 2 commits into from
Jan 30, 2021

Conversation

datdamnzotz
Copy link

@datdamnzotz datdamnzotz commented Jan 22, 2021 •
edited
Loading

Add length to 64 for suffix.
Fixes #504

Checklist:

  • The code change is tested and works locally.
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if necessary
  • There is no commented out code in this PR.
  • My changes generate no new warnings (check the console)

@datdamnzotz
Fixes Orcpub#504
0473d55 
Add length to 64 for suffix.
@datdamnzotz datdamnzotz added bug Something isn't working area/application Task related to orcpub application itself labels Jan 22, 2021
@datdamnzotz datdamnzotz added this to the 2.5.0.21 milestone Jan 22, 2021
@datdamnzotz datdamnzotz self-assigned this Jan 22, 2021
@datdamnzotz
Fixes for lint errors:
aff3296 
src\cljc\orcpub\dice.cljc:42:17: warning: Single arg use of or always returns the arg itself
src\cljc\orcpub\dice.cljc:60:17: warning: Single arg use of or always returns the arg itself
@codeGlaze codeGlaze merged commit 2717adc into Orcpub:develop Jan 30, 2021
@datdamnzotz datdamnzotz changed the title Fixes #504 [Bug] Email address validator doesn't comply with new TLD Fixes #503 [Bug] Email address validator doesn't comply with new TLD Jan 30, 2021
@datdamnzotz
Copy link
Author

Fixes #503

@datdamnzotz datdamnzotz deleted the #503_email_address_validator branch January 30, 2021 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeGlaze codeGlaze codeGlaze approved these changes

Assignees

@datdamnzotz datdamnzotz

Labels
area/application Task related to orcpub application itself bug Something isn't working
Projects
None yet
Milestone
2.5.0.21
Development

Successfully merging this pull request may close these issues.
2 participants
@datdamnzotz @codeGlaze